deprecate builders and add setters for domain classes#596
Merged
Conversation
artursouza
reviewed
Aug 18, 2021
| /** | ||
| * Builds a request to delete a state by key. | ||
| * Deprecated in favor of @see{@link DeleteStateRequest}. | ||
| * Deprecated since SDK version 1.3.0, slated for Removal in SDK version 1.5.0. |
Contributor
There was a problem hiding this comment.
nit: lowercase r for removal.
exclude builders from coverage checks properly set parallelism for getbulkstaterequest Initialize default metadata to empty HashMap PublishEventRequest Decrease code coeverage ratio for dapr-sdk
mukundansundar
force-pushed
the
deprecate-builders
branch
from
cc3662d to
1dfdfa9
Compare
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
============================================
- Coverage 80.90% 77.05% -3.85%
+ Complexity 990 941 -49
============================================
Files 88 88
Lines 3042 3011 -31
Branches 332 334 +2
============================================
- Hits 2461 2320 -141
- Misses 412 528 +116
+ Partials 169 163 -6
Continue to review full report at Codecov.
|
artursouza
approved these changes
Aug 20, 2021
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
* deprecate builders and add setters for domain classes exclude builders from coverage checks properly set parallelism for getbulkstaterequest Initialize default metadata to empty HashMap PublishEventRequest Decrease code coeverage ratio for dapr-sdk * Fix casing Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
* deprecate builders and add setters for domain classes exclude builders from coverage checks properly set parallelism for getbulkstaterequest Initialize default metadata to empty HashMap PublishEventRequest Decrease code coeverage ratio for dapr-sdk * Fix casing Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #587
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #587
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: